Skip to content

feat: warn when libc debug info is not found - #310

Merged
not-matthias merged 1 commit into
mainfrom
cod-2536-warn-when-libc-dbginfo-is-not-found
Apr 23, 2026
Merged

feat: warn when libc debug info is not found#310
not-matthias merged 1 commit into
mainfrom
cod-2536-warn-when-libc-dbginfo-is-not-found

Conversation

@not-matthias

Copy link
Copy Markdown
Member

When a stripped libc is loaded without a matching debug file (no .debug_info section and no match via build-id or .gnu_debuglink), emit a warning pointing users at libc6-dbg / glibc-debuginfo so they know why libc frames show as unknown symbols.

@codspeed-hq

codspeed-hq Bot commented Apr 22, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 4 untouched benchmarks


Comparing cod-2536-warn-when-libc-dbginfo-is-not-found (7e93351) with main (9b26b2b)

Open in CodSpeed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a targeted warning when a stripped libc is loaded without embedded DWARF and no separate debug file can be located, guiding users to install distro debuginfo packages so libc frames don’t show up as unknown symbols.

Changes:

  • Emit a warning before failing when no DWARF and no separate debug file is found.
  • Add libc-specific detection to suggest installing libc6-dbg / glibc-debuginfo.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/executor/wall_time/perf/debug_info.rs Outdated
Comment thread src/executor/wall_time/perf/debug_info.rs Outdated
Comment thread src/executor/wall_time/perf/debug_info.rs Outdated
Comment thread src/executor/wall_time/perf/debug_info.rs

@GuillaumeLagrange GuillaumeLagrange left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comments

Comment thread src/executor/wall_time/perf/debug_info.rs Outdated
Comment thread src/executor/wall_time/perf/debug_info.rs Outdated
Comment thread src/executor/wall_time/perf/debug_info.rs Outdated

@GuillaumeLagrange GuillaumeLagrange left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meant to approve

When a stripped libc is loaded without a matching debug file (no
.debug_info section and no match via build-id or .gnu_debuglink),
emit a warning pointing users at libc6-dbg / glibc-debuginfo so
they know why libc frames show as unknown symbols.

Refs COD-2536
@not-matthias
not-matthias force-pushed the cod-2536-warn-when-libc-dbginfo-is-not-found branch from e8cfad8 to 7e93351 Compare April 23, 2026 08:55
@not-matthias
not-matthias merged commit 7e93351 into main Apr 23, 2026
18 checks passed
@not-matthias
not-matthias deleted the cod-2536-warn-when-libc-dbginfo-is-not-found branch April 23, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants